[rc2] Fix complex collection type in model snapshot #36620
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
approved these changes
Aug 21, 2025
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36619
Description
The generated model snapshot that is used in migrations specifies an incorrect type for the complex collections (the element type is used instead of the collection type).
Customer impact
The incorrect snapshots cause redundant operations to be generated in every migration even when the model is not changed. This is usually just an annoyance, but would cause an exception if the user has "throw on warnings" enabled.
How found
RC1 validation
Regression
No, complex collections are a new feature in 10
Testing
Test added
Risk
Low, the code only affects the new feature