Skip to content

[rc2] Optimize FindIndexerPropertyInfo methods to avoid unnecessary reflection calls #36648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 2 commits into from
Aug 26, 2025
Merged

[rc2] Optimize FindIndexerPropertyInfo methods to avoid unnecessary reflection calls #36648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84e3551
Initial plan
Copilot Aug 25, 2025
0e7528f
Fix inefficiency in FindIndexerPropertyInfo methods
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/Internal/Model.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ private Model MakeReadonly()
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public virtual PropertyInfo? FindIndexerPropertyInfo(Type type)
=> _indexerPropertyInfoMap.GetOrAdd(type, type.FindIndexerProperty());
=> _indexerPropertyInfoMap.GetOrAdd(type, static t => t.FindIndexerProperty());

/// <summary>
/// Gets a value indicating whether the given MethodInfo represents an indexer access.
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/RuntimeModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ private string GetDisplayName(Type type)
=> _clrTypeNameMap.GetOrAdd(type, t => t.DisplayName());

private PropertyInfo? FindIndexerPropertyInfo([DynamicallyAccessedMembers(IEntityType.DynamicallyAccessedMemberTypes)] Type type)
=> _indexerPropertyInfoMap.GetOrAdd(type, type.FindIndexerProperty());
=> _indexerPropertyInfoMap.GetOrAdd(type, static t => t.FindIndexerProperty());

/// <summary>
/// This is an internal API that supports the Entity Framework Core infrastructure and not subject to
Expand Down
Loading