Skip to content

[rc2] Fix EditionOptions missing from Down() method in initial migrations #36649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[rc2] Fix EditionOptions missing from Down() method in initial migrations #36649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcecbe6
Initial plan
Copilot Aug 25, 2025
ad44498
Fix EditionOptions missing from Down() method in initial migrations
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.SqlServer/Migrations/Internal/SqlServerMigrationsAnnotationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public SqlServerMigrationsAnnotationProvider(MigrationsAnnotationProviderDepende

/// <inheritdoc />
public override IEnumerable<IAnnotation> ForRemove(IRelationalModel model)
=> model.GetAnnotations().Where(a => a.Name != SqlServerAnnotationNames.EditionOptions);
=> model.GetAnnotations();

/// <inheritdoc />
public override IEnumerable<IAnnotation> ForRemove(ITable table)
Expand Down
27 changes: 27 additions & 0 deletions test/EFCore.SqlServer.Tests/Migrations/SqlServerModelDifferTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,33 @@ public void Alter_database_edition_options()
alterDatabaseOperation.OldDatabase[SqlServerAnnotationNames.EditionOptions]);
});

[ConditionalFact]
public void Create_database_with_edition_options()
=> Execute(
_ => { },
source => { },
target => target.HasDatabaseMaxSize("10"),
upOps =>
{
Assert.Equal(1, upOps.Count);

var alterDatabaseOperation = Assert.IsType<AlterDatabaseOperation>(upOps[0]);
Assert.Equal(
"MAXSIZE = 10",
alterDatabaseOperation[SqlServerAnnotationNames.EditionOptions]);
Assert.Null(alterDatabaseOperation.OldDatabase[SqlServerAnnotationNames.EditionOptions]);
},
downOps =>
{
Assert.Equal(1, downOps.Count);

var alterDatabaseOperation = Assert.IsType<AlterDatabaseOperation>(downOps[0]);
Assert.Null(alterDatabaseOperation[SqlServerAnnotationNames.EditionOptions]);
Assert.Equal(
"MAXSIZE = 10",
alterDatabaseOperation.OldDatabase[SqlServerAnnotationNames.EditionOptions]);
});

[ConditionalFact]
public void Alter_table_MemoryOptimized()
=> Execute(
Expand Down