Add test covering querying of complex type on view #37364
Merged
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
ComplexTypeWithView
branch
from
c29dd77 to
d7e7314
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for querying complex types on entities that are mapped to both a table and a view, addressing issue #34706.
- Adds a functional test that verifies complex types work correctly when an entity is mapped to both a database table and a view
- Validates that EF Core properly queries from the view and materializes complex type properties
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/EFCore.Relational.Specification.Tests/Query/AdHocComplexTypeQueryRelationalTestBase.cs | Adds the base test method Complex_type_on_an_entity_mapped_to_view_and_table with test context, model configuration, view creation, data seeding, and assertions |
| test/EFCore.SqlServer.FunctionalTests/Query/AdHocComplexTypeQuerySqlServerTest.cs | Adds SQL Server-specific override that asserts the generated SQL queries the view correctly and selects complex type columns |
test/EFCore.Relational.Specification.Tests/Query/AdHocComplexTypeQueryRelationalTestBase.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
ComplexTypeWithView
branch
from
d7e7314 to
fe23b47
Compare
AndriySvyryd
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34706