Revert incorrect resource file DependentUpon changes#37518
Closed
Copilot wants to merge 3 commits intorelease/10.0from
Closed
Revert incorrect resource file DependentUpon changes#37518Copilot wants to merge 3 commits intorelease/10.0from
Copilot wants to merge 3 commits intorelease/10.0from
Conversation
- Add explicit EmbeddedResource Update for Properties\Resources.resx - Change DependentUpon for Resources.Designer.cs from .tt to .resx - This prevents MSBuild glob expansion issues with resource files Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…Core - Add explicit EmbeddedResource Update for Properties\Resources.resx - Change DependentUpon for Resources.Designer.cs from .tt to .resx - Ensures consistency with ef and dotnet-ef projects Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix exception thrown by dotnet-ef version 10.0.2
Fix resource file DependentUpon to prevent MSBuild glob expansion errors
Jan 15, 2026
Copilot
AI
changed the title
Fix resource file DependentUpon to prevent MSBuild glob expansion errors
Revert incorrect resource file DependentUpon changes
Jan 15, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous changes incorrectly modified
DependentUponfromResources.Designer.tttoResources.resxin an attempt to fix MSBuild's**/*.resxglob expansion error. This error is actually an MSBuild SDK bug (dotnet/sdk#10172) triggered when directories with special characters exist in user projects, not an EF Core issue.Changes
Reverted the following in 4 csproj files (
ef,dotnet-ef,EFCore.Tasks,Microsoft.Data.Sqlite.Core):<EmbeddedResource Update>blocks forProperties\Resources.resx<DependentUpon>Resources.Designer.tt</DependentUpon>(was incorrectly changed toResources.resx)Root Cause
The T4 templates (
Resources.Designer.tt) correctly generate theResources.Designer.csfiles from.resxsources. MSBuild's default SDK behavior already includes**/*.resxas embedded resources. The dependency chain was correct as-is.The reported error occurs when user projects contain directories with special characters (e.g.,
D:\Processedwith a colon), causing MSBuild's glob pattern matcher to fail - this is beyond EF Core's control.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.