Low memory footprint... (Initial stubbed-out top-level API) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the API surface required to build the version of Music Store checked in. No implementation as yet, and some things (like Database.Create) will likely change.
|
Looks good to me. |
|
|
||
| public static class QueryableExtensions | ||
| { | ||
| public static IQueryable<T> Include<T, TProperty>( |
There was a problem hiding this comment.
I think we should leave Include out since we aren't planning to have it around to start with.
There was a problem hiding this comment.
Assuming MusicStore currently depends on it, I think we can leave it in until we figure out what to replace it with.
|
Signed off with comments |
|
You guys should use the |
emoticon : shipit : 😄
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the API surface required to build the version of Music Store checked in. No implementation as yet, and some things (like Database.Create) will likely change.