Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency detection for query, save changes, and ADO command execution #4051

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

mikary
Copy link
Contributor

@mikary mikary commented Dec 11, 2015

@mikary
Copy link
Contributor Author

mikary commented Dec 11, 2015

For Query, it was not necessary to add guards on the QueryCompiler for the single result path because the guard is already compiled into the query.


public virtual void EnterCriticalSection()
{
if(_isInCriticalSection++ != 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the previous value when setting has more potential of ending up with an unexpected value in concurrency scenarios making this potentially less effective. Just use a bool and assign a constant

@ajcvickers
Copy link
Member

:shipit: Looks good to me once comments addressed.

@mikary mikary merged commit eece19d into dev Dec 15, 2015
@mikary mikary deleted the asyncGuard branch December 15, 2015 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants