NuGet Commands: Drop-Database #4907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| Reporter.Output.WriteLine(message); | ||
| Reporter.Output.WriteLine( | ||
| $"Are you sure you want to drop the database '{database}' on server '{dataSource}'? (y/N)"); | ||
| var readedKey = Console.ReadKey().KeyChar; |
There was a problem hiding this comment.
shouldn't we skip read altogether this if --force was used?
|
It looks like Otherwise, |
|
Thanks. I'll do a bit of bashing on this too before merging. |
| param ($database, $dataSource) | ||
|
|
||
| return $PSCmdlet.ShouldProcess("$database on $dataSource") | ||
| } |
There was a problem hiding this comment.
Bad news. This results in Cannot serialize delegates over unmanaged function pointers, dynamic methods or methods outside the delegate creator's assembly. 😞
|
Recalling. We need to rethink how the confirmation works. One idea @natemcmaster had was to get the information in a separate command (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes from #4657. Only 03f95a2 needs review.
cc @natemcmaster @laskoviymishka (aka Rarity)
Resolves #2476