Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when SqlServer ValueGenerationStrategy is configured on an incompatible property by a convention #7301

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

AndriySvyryd
Copy link
Member

Fixes #7208

Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see if my understanding of this issue is correct:

  • We don't have any conventions that do this
  • If somebody writes a convention to do this, then that convention would be wrong because it is not valid to have this strategy set on an incompatible property

Would it therefore not be better to continue to issue the error? Or are there some cases where it the error is being issued erroneously and it is in fact valid to have the strategy set on the property.

Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @AndriySvyryd and I now understand why this makes sense given the way these APIs have been designed. So signing off. But I'm still concerned that this seems like code that will never actually be needed, so filed #7410 to cover that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants