Dissolve Relational.Design package #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Jun 2, 2017
There was a problem hiding this comment.
Pre-approving this since it is just mechanical work getting everything rebased. Probably good for @bricelam to give a quick scan of this tomorrow.
bricelam
approved these changes
Jun 2, 2017
| .AddSingleton<CSharpDbContextGenerator>() | ||
| .AddSingleton<CSharpEntityTypeGenerator>() | ||
| .AddSingleton<ScaffoldingTypeMapper>() | ||
| .AddSingleton<ScaffoldingCodeGenerator, CSharpScaffoldingGenerator>() |
There was a problem hiding this comment.
File an issue to add interfaces and dependency objects to these where applicable.
This was referenced Jun 2, 2017
Not useful at all.
Remove CustomConfiguration
Rewrite code writers to work directly from Model
Remove Sqlite.Design.Tests Introduce IScaffoldingHelper interface which provider overwrites to generate provider specific code in scaffolding pipeline
Remove special processing around type mapping in SqlServerScaffoldingModelFactory Change ColumnModel.StoreType to have fully qualified type name for ScaffoldingTypeMapper
…s extension for easy formatting
Remove SqlServer.Design.Tests Introduce IAnnotationRenderer interface for provider writers to provide us how to interpret annotations Flow annotations from DatabaseModel to IModel so that provider can generate provider specific fluent API Remove special processing inside of SqlServerScaffoldingFactory. All processing should happen while generating database
smitpatel
force-pushed
the
feature/removerelationaldesign
branch
from
7449cd6
to
778a843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7004
I am adding more commits to this branch as I cherry-pick them from previous branches (since rebase is having too many merge conflicts)
@roji @ErikEJ - This will be final PR which removes Relational.Design package altogether. I will write detailed note on the issue on what changed and what is provider supposed to do when this goes in. Feel free to give any feedback on PR if you want.