Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Logging from Design #8968

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Remove Logging from Design #8968

merged 1 commit into from
Jun 27, 2017

Conversation

bricelam
Copy link
Contributor

Resolves #8686

<value>Found a column on index {indexName} on table {tableName} with an empty or null name. Not including column in index.</value>
<comment>Warning SqlServerEventId.IndexColumnNotNamedWarning string string</comment>
</data>
<data name="LogColumnNameEmptyOnIndex" xml:space="preserve">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning MSB3568: Duplicate resource name "LogColumnNameEmptyOnIndex" is not allowed, ignored.

Will fix.

@bricelam
Copy link
Contributor Author

(Made a few more changes to assertions in SqlServerE2ETests to get tests passing.)

@ajcvickers
Copy link
Contributor

🐑🇮🇹 😸 :

@bricelam bricelam merged commit 824ada9 into dotnet:dev Jun 27, 2017
@bricelam bricelam deleted the log branch June 27, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants