Merge upstream 3.1.56 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to test c++17 since that is the default used, but we should ensure we maintain compatibility with c++11.
The C++ functions that take `std::nothrow_t` all take a reference. Without this change I'm seeing function signature mismatches because the final argument is not pointer-width. I'm guessing this simply went unnoticed because most platforms don't do signature checking in the linker and this just happens to work. e.g. `_ZnwjRKSt9nothrow_t` which demangles to `operator new(unsigned int, std::nothrow_t const&)` See upstream bug at microsoft/mimalloc#840.
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.5 to 3.23.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@74483a3...0b21cf2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ipten-core#21103) This allows us to use `compiler_for` to determine whether to run `EMCC` or `EMXX` appropriately.
For some reason this actually saves on code size too.
Fixes test browser.test_webgpu_basic_rendering_closure by fixing wgpuShaderModuleGetCompilationInfo (compilationInfo.messages.length). Fixes: emscripten-core#20415
There was only one single place (out of hundreds) where this was set and one single place in `doStat` where it was read. I removed the `doStat` workaround by updating `mayLookup` instead.
…ore#21138) Also remove the special logging and just use assert which fails fast and gives a backtrace.
Split out from emscripten-core#21151. The only semantic change here is the fix the type of second argument to to the array member getter function (previously it was using `m.type` which is the array type itself, but that second argument to the setter function is actually the inner type `m.type.inner`. This enables the type of this argument to be checked correctly, which in turn required a minor fix to the test case. This only effects `IDL_CHECKS=all` builds.
This was used to demangle C++ symbols JS stacktraces. However for a long time now native symbols in JS backtraces are already demanged because names in the name section are in demangled form. So this function has not done anything for a very long time. As a followup I think we can probably completely remove the `DEMANGLE_SUPPORT` settings.
Co-authored-by: Jerry.Zhuang <jerry.zhuang@jwzg.com>
…re#21170) I noticed that `proc_exit` was depending on `SYSCALLS` even though it wasn't actually using `SYSCALLS`.
…1168) Previously, AOT JS glue code for method pointers used the address of the method pointer as a unique ID to match JS glue with the binding. However, sometimes static initializers malloc different sizes when running the AOT generation code versus when the code is run normally. This caused the method pointer address to be different and the binding didn't match up. Instead of using the function pointer or the method pointer address we now use a generated signature for the invoker to match up the glue code. This works for both types of pointers and also has the advantage that many of the glue code functions are nearly identical and can be reusued (closure arguments make them behave differently). Fixes emscripten-core#20994
This chance also includes a couple of minor fixes to asan + memory64 that helped me to confirm that it really doesn't work yet. See emscripten-core#21177
The poppler test also seesm to work fine under wasm64, just not the >4Gb mode.
Also add test_TextDecoder to the list of test.
I think the recent SDL2 version bump must have fixed the issues we were previously seeing. See emscripten-core#21337 and emscripten-core#20417.
All the browsers we test against these days support threads
Should have been part of emscripten-core#21490.
This test was disabled due to EM_ASM not working in side modules but that was fixed in emscripten-core#18228.
…1505) The usage of genArgSequence removed in emscripten-core#17420. The usage of needsQuoting was removed in emscripten-core#17462
…core#21487) Fixes a few Closure lint warnings. (Though of course there are very many other Closure warnings.)
emscripten-core#21501) This fixes cases like this: function ([, a]) { } In such arrays it is possible to have empty elements, which must be skipped.
As of today all `.mjs` files are part of the compiler itself and don't contains preproccess macros, so that are safe to be run through linter tools.
…cripten-core#21499) This means that even in CI when we might skip certain tests for graphics or sounds we still get some assurance that the test code compiles.
This port is used by the goma compiler webserver which causes these tests to fail on machines that are running the goma compiler.
Instead just pass them through the linker like other inputs. See emscripten-core#21128
…ore#21511) Also, avoid the use of `abort` in this case since abort itself depends on `WebAssembly.RuntimeError`. Fixes: emscripten-core#21484
On systems that don't have the requests python we cannot catch this exception.
And also for CLOSURE_WARNINGS
lewing
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.