Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set IsAotCompatible=true for Microsoft.AspNetCore.HeaderParsing #4914

Closed
eerhardt opened this issue Jan 29, 2024 · 0 comments · Fixed by #5368
Closed

Set IsAotCompatible=true for Microsoft.AspNetCore.HeaderParsing #4914

eerhardt opened this issue Jan 29, 2024 · 0 comments · Fixed by #5368
Assignees
@eerhardt
Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@eerhardt
Copy link
Member

With #4871 all projects in src/Libraries were marked as AOT compatible, so the trim and AOT analyzers run during the build.

The only library that couldn't be marked is Microsoft.AspNetCore.HeaderParsing. This is because it is blocked on dotnet/runtime#94547.

extensions/src/Libraries/Microsoft.AspNetCore.HeaderParsing/Microsoft.AspNetCore.HeaderParsing.csproj

Lines 11 to 12 in a44a76e

<!-- blocked by https://github.com/dotnet/runtime/issues/94547 -->
<IsAotCompatible>false</IsAotCompatible>

When the underlying runtime bug is fixed we should enable the config source generator in this library and mark it as AOT compatible.
@geeknoid geeknoid added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed untriaged labels Mar 16, 2024
eerhardt added a commit to eerhardt/extensions that referenced this issue Aug 16, 2024
@eerhardt
Use Configuration Binder in HeaderParsing
fbc2ef8 
dotnet/runtime#94547 has been fixed in 9.0. We can now use the Configuration Binder in HeaderParsing.

This fixes the last AOT warning in the repo.

Fix dotnet#4914
@eerhardt eerhardt mentioned this issue Aug 16, 2024
Merged
RussKie pushed a commit that referenced this issue Aug 19, 2024
@eerhardt
Use Configuration Binder in HeaderParsing (#5368)
13b95bb 
dotnet/runtime#94547 has been fixed in 9.0. We can now use the Configuration Binder in HeaderParsing.

This fixes the last AOT warning in the repo.

Fix #4914
@RussKie RussKie linked a pull request Aug 19, 2024 that will close this issue
Use Configuration Binder in HeaderParsing #5368
Merged
@RussKie RussKie closed this as completed Aug 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Configuration Binder in HeaderParsing eerhardt/extensions
3 participants
@RussKie @eerhardt @geeknoid