Use Arcade to manage .NET Core installation and remove custom logger download #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on dotnet/arcade#2725 |
JunTaoLuo
reviewed
May 9, 2019
JunTaoLuo
approved these changes
May 9, 2019
|
Now blocked on dotnet/arcade#2730 |
|
CI checks on Windows timeout after an hour, which is bizarre. It looks like the new installer is getting the right bits, but I wonder if it's also doing something that is causing .NET Core to slow down like 100x on Windows. Don't merge yet - let's investigate what's going on. Might be related to dotnet/arcade#2744 |
natemcmaster
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes copies of our dotnet-install scripts in favor of a new Arcade feature that installs .NET Core runtimes for us.
(kudos to @chcosta)