Catch all exceptions from Exit shutdown #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
reviewed
Jul 25, 2019
jkotalik
force-pushed
the
jkotalik/genericHostConsoleException
branch
from
f5dfebd to
139b335
Compare
|
🆙 📅 . I could hack together a test where I replace the IConsole, but I would need to make _messageQueue internal and do a bit of other magic. |
BrennanConroy
approved these changes
Jul 26, 2019
ghost
deleted the
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as dotnet/aspnetcore#12518 except in master and with generic host.
TODO I think I can test this one with a bad logger. I'll take a stab at it.