Skip to content

Fix unintended breaking change #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Conversation

dougbu
Copy link

@dougbu dougbu commented Aug 11, 2019

- blocking dotnet/aspnetcore#1293 dependency update PR
- commit 3ec8c35 lost `AssemblyName` substitution
  - tasks assembly in package incorrectly named ".Manifest.Task.dll"
@dougbu dougbu requested a review from a team August 11, 2019 18:33
@dougbu
Copy link
Author

dougbu commented Aug 11, 2019

Intend to get this in as soon as possible to fix the package and unblock dependency flow. If you're around, have a look @JunTaoLuo

@dougbu dougbu merged commit 77403f3 into release/3.0 Aug 11, 2019
@ghost ghost deleted the dougbu/fix.manifest.task branch August 11, 2019 21:12
Copy link

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-hoc :shipit:

@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants