Added verification test for resolving singleton from scoped container. #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to follow up with Unity to have them fix this? |
pakrym
approved these changes
Aug 28, 2019
Look at the linked bug. |
ghost
deleted the
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 17, 2020
dotnet/extensions#2236) * Added verification test for resolving singleton from scoped container. * Skip failing test with the Unity container Commit migrated from dotnet/extensions@732d143
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
dotnet/extensions#2236) * Added verification test for resolving singleton from scoped container. * Skip failing test with the Unity container Commit migrated from dotnet/extensions@732d143
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Apr 13, 2020
dotnet/extensions#2236) * Added verification test for resolving singleton from scoped container. * Skip failing test with the Unity container Commit migrated from dotnet/extensions@732d143
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when investigating why unity was broken on 2.2. The container instance passed to singleton isn't the scoped service provider.
Closes #1301