Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a convenience API for using timer in the right way #395

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Add a convenience API for using timer in the right way #395

merged 1 commit into from
Sep 11, 2018

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Sep 9, 2018

@rynowak rynowak requested a review from davidfowl September 9, 2018 23:21
@rynowak
Copy link
Member Author

rynowak commented Sep 9, 2018

I know I have to do a build system thing in aspnet/Universe, will wait to sort that out until this is signed off.

@benaadams benaadams mentioned this pull request Sep 9, 2018
Closed
@JamesNK
Copy link
Member

JamesNK commented Sep 10, 2018

Is this something that could be checked for with code analysis? (note: not in this PR)

@rynowak
Copy link
Member Author

rynowak commented Sep 10, 2018

everything can be checked with code analysis if you're determined enough

@rynowak rynowak merged commit 6583623 into release/2.2 Sep 11, 2018
@rynowak rynowak deleted the rynowak/non-capturing-timer branch September 11, 2018 19:42
@rynowak
Copy link
Member Author

rynowak commented Sep 11, 2018

@benaadams - where did the fixes for this go in? Razor, HttpClientFactory, FileProviders, ??? others ???

@rynowak rynowak restored the rynowak/non-capturing-timer branch September 11, 2018 19:55
@benaadams
Copy link
Member

aspnet/Razor#2565, aspnet/SignalR#2904, aspnet/HttpClientFactory#172

FileProviders was fixed by #392 which is similar, but different

@natemcmaster natemcmaster deleted the rynowak/non-capturing-timer branch October 25, 2018 00:26
natemcmaster pushed a commit that referenced this pull request Nov 7, 2018
@tstanitz @Tratcher
MemoryCache generic TryGetValue return false when incompatible type u…
d0da61a 
…sed (#395)
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rynowak @JamesNK @benaadams @davidfowl