Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @msftbot automation #3984

Merged
merged 1 commit into from
May 23, 2023
Merged

Add @msftbot automation #3984

merged 1 commit into from
May 23, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented May 23, 2023

For the most part this is a stripped down copy from https://github.com/dotnet/winforms/blob/main/.github/fabricbot.json which I authored over the years. I aligned the labels in this repo to match.

@RussKie RussKie requested a review from joperezr May 23, 2023 07:42
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable. do we need to do anything to make fabricbot start reading this?

later we'll probably want to look at runtime/aspnetcore ones for any other goodness.

@danmoseley danmoseley merged commit bd88ee2 into dotnet:main May 23, 2023
@ghost ghost assigned RussKie May 23, 2023
@joperezr
Copy link
Member

Thanks for adding this @RussKie. I had a couple of comments and have addressed them here: #3988

@RussKie RussKie deleted the add_msftbot branch May 23, 2023 23:15
geeknoid pushed a commit that referenced this pull request May 23, 2023
@RussKie
Copy link
Member Author

RussKie commented May 24, 2023

do we need to do anything to make fabricbot start reading this?

No, once the config is in, the bot starts using it instead of a config stored in its database somewhere.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants