Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on probes and health checks. #4042

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Work on probes and health checks. #4042

merged 1 commit into from
Jun 9, 2023

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Jun 8, 2023

  • Introduce probe functionality. Basic abstractions and k8s implementation.

  • Streamline the APIs for health checks by removing needless overloads.

  • Rename the HealthChecks.Core package to HealthChecks.Common

  • Improve the health status produced by the application lifecycle health check to indicate why it is unhealthy.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned geeknoid Jun 8, 2023
@geeknoid geeknoid requested review from dotnet-bot, tekian and dbarbosapn and removed request for dotnet-bot June 8, 2023 13:21
- Introduce probe functionality. Basic abstractions and k8s
implementation.

- Streamline the APIs for health checks by removing needless overloads.

- Rename the HealthChecks.Core package to HealthChecks.Common
Copy link
Contributor

@dbarbosapn dbarbosapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@geeknoid geeknoid removed the request for review from tekian June 9, 2023 13:00
@geeknoid geeknoid merged commit f4952b6 into main Jun 9, 2023
@geeknoid geeknoid deleted the geeknoid/probes branch June 9, 2023 13:12
@ghost ghost added this to the 8.0 Preview6 milestone Jun 9, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2023
@RussKie
Copy link
Member

RussKie commented Jul 12, 2023

@geeknoid @dbarbosapn I missed this pull request, but essentially any changes in our package offering - i.e., an addition, a removal or name change of a package must be reflected in https://github.com/dotnet/api-catalog-infra/ so that the Docs team has the right content for the API docs. You can use https://github.com/dotnet/api-catalog-infra/pull/68 as a reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants