Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable code coverage reporting #4046

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Re-enable code coverage reporting #4046

merged 1 commit into from
Jun 21, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Jun 8, 2023 •
edited by ghost
Loading

Each build leg (i.e., Windows and Ubuntu) produce their respective code coverage reports, which are then get merged by CodeCoverageReport build job. This job then generates and publishes an HTML report:
image

⚠️ The code coverage validation and enforcement are still pending and will be enabled later.

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested review from joperezr and geeknoid June 8, 2023 04:19
@ghost ghost assigned RussKie Jun 8, 2023
@RussKie RussKie force-pushed the cc branch 2 times, most recently from 6377a7c to 042f62b Compare June 8, 2023 08:24
@RussKie RussKie marked this pull request as draft June 9, 2023 00:52
@RussKie
Copy link
Member Author

RussKie commented Jun 9, 2023

I'm still trying to figure out the inclusion pattern (see microsoft/codecoverage#33).

@joperezr joperezr mentioned this pull request Jun 9, 2023
Merged
joperezr
joperezr reviewed Jun 9, 2023
View reviewed changes
eng/CodeCoverage.config Outdated Show resolved Hide resolved
joperezr
joperezr reviewed Jun 9, 2023
View reviewed changes
eng/CodeCoverage.config Outdated Show resolved Hide resolved
joperezr
joperezr reviewed Jun 9, 2023
View reviewed changes
build.cmd Outdated Show resolved Hide resolved
@RussKie
Re-enable code coverage reporting
69fc1a6 
Each build leg (i.e., Windows and Ubuntu) produce their respective code
coverage reports, which are then get merged by `CodeCoverageReport`
build job. This job then generates and publishes an HTML report.

NB: The code coverage validation and enforcement are still pending and
will be enabled later.
@RussKie RussKie marked this pull request as ready for review June 21, 2023 00:24
@RussKie RussKie merged commit 78375bf into main Jun 21, 2023
@RussKie RussKie deleted the cc branch June 21, 2023 02:11
@ghost ghost added this to the 8.0 Preview6 milestone Jun 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr left review comments

@geeknoid geeknoid geeknoid approved these changes

Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
8.0 Preview6
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @joperezr @geeknoid