Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.Extensions.Telemetry.csproj #4072

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Update Microsoft.Extensions.Telemetry.csproj #4072

merged 1 commit into from
Jun 14, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Jun 14, 2023 •
edited
Loading

Contributes to #4073

Remove superficial IVT entry.

This entry makes the compiler very upset when signing is disabled, which has to be to appease stryker (the mutation test runner).

D:\Development\azure-dotnet-extensions-experimental\tests\Microsoft.Azure.Extensions.Telemetry.Tests\AzureMetadataTests.cs(16,22): error CS0281: Friend access was granted by 'Microsoft.Extensions.Telemetry, Version=8.0.0.0, Culture=neutral, PublicKeyTok 
en=31bf3856ad364e35', but the public key of the output assembly ('') does not match that specified by the InternalsVisibleTo attribute in the granting assembly. [D:\Development\azure-dotnet-extensions-experimental\tests\Microsoft.Azure.Extensions.Teleme 
try.Tests\Microsoft.Azure.Extensions.Telemetry.Tests.csproj::TargetFramework=net8.0]
Microsoft Reviewers: Open in CodeFlow

@RussKie
Update Microsoft.Extensions.Telemetry.csproj
98a9505 
Remove superficial IVT entry
@RussKie RussKie requested a review from geeknoid June 14, 2023 07:46
@ghost ghost assigned RussKie Jun 14, 2023
@RussKie RussKie mentioned this pull request Jun 14, 2023
Closed
@RussKie RussKie merged commit aee3957 into main Jun 14, 2023
@RussKie RussKie deleted the RussKie-patch-1 branch June 14, 2023 22:58
@ghost ghost added this to the 8.0 Preview6 milestone Jun 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafal-mz rafal-mz rafal-mz approved these changes

@geeknoid geeknoid geeknoid approved these changes

Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
8.0 Preview6
Development

Successfully merging this pull request may close these issues.
3 participants
@RussKie @geeknoid @rafal-mz