Resolve a "FIXME" in Options.Validation #4111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RussKie FYI |
xakep139
changed the title
|
Why do we need this change? We should be deleting the stuff in ToBeRemoved if possible, rather than patching it... |
|
🤦♂️ my bad, haven't noticed the folder name. I was viewing the code via VS in solution view only. Abandoning the PR. |
|
Yes, this is being worked on in dotnet/runtime somewhere... |
|
I guess this is dotnet/runtime#84347 and dotnet/runtime#86511? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up after dotnet/runtime#84280 was merged
Microsoft Reviewers: Open in CodeFlow