Ensure reference isolation #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use TestOnly.props only for test projects * Move analyzer references from BuildOnly.props to General.props * Remove BuildOnly.props as it contains unused references
geeknoid
approved these changes
Jun 29, 2023
xakep139
reviewed
Jun 29, 2023
| @@ -1,4 +1,6 @@ | |||
| <Project> | |||
| <Import Project="$(MSBuildThisFileDirectory)\..\eng\packages\TestOnly.props" /> | |||
There was a problem hiding this comment.
Why do we need test-related props in benchmarks?
There was a problem hiding this comment.
The benchmarks (at least some of those) are, essentially, test projects, so they too have test-only dependencies. We can iterate on this in the future, but the main goal here is to ensure the shippable artifacts don't accidentally pull in test-only dependencies.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow