Get coverage numbers up #4279
Merged
Get coverage numbers up #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -653,16 +654,19 @@ private void Diag(DiagnosticDescriptor desc, Location? location, params object?[ | |||
| _reportDiagnostic(Diagnostic.Create(desc, location, messageArgs)); | |||
| } | |||
|
|
|||
| [ExcludeFromCodeCoverage] | |||
There was a problem hiding this comment.
Is it because the compiler generates some code that is never accessed?
If so I would assume that compiler generated code could be excluded and the tool should have an option for that.
There was a problem hiding this comment.
I filed a bug about this against Roslyn. Not all the generated code in a record type is properly annotated. The properties for example don't have annotations. So it messes up coverage.
geeknoid
force-pushed
the
geeknoid/cov
branch
4 times, most recently
from
b3b8b1e
to
6abf449
Compare
|
I suggest pushing this change in to the internal repo and kicking off an internal build to verify it builds successfully. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow