[release/8.0] Fix "DuplicateRequestName" error message missing requestName argument #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xakep139
approved these changes
Sep 6, 2023
dbarbosapn
approved these changes
Sep 6, 2023
geeknoid
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update dependencies from https://github.com/dotnet/aspnetcore build 20230901.19 (#4347) Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rc.2.23431.20 -> To Version 8.0.0-rc.2.23451.19 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20230901.1 (#4351) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.23451.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20230903.2 (#4349) Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rc.2.23451.19 -> To Version 8.0.0-rc.2.23453.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix "DuplicateRequestName" error message missing requestName argument (#4358) Co-authored-by: Diogo Barbosa <diogobarbosa@microsoft.com> * Major update to the logging generator. (#4360) - Now has full support for modern data classifications, including combined data classifications (where two annotations apply to the same piece of state). - Fix some bugs around putting spurious @ in logging property names in certain cases. - Improved many error paths by eliminating cascading errors. You now tend to just get one clean error. - Simplify [LogProperties] and create the [TagProvider] attribute. Both features are orthogonal, they should never have been provided by a single attribute. - Dynamically adjust the name of the generated static variables in order to avoid conflicts with user-created symbols. - Harmonize transitive behavior. When you apply [LogProperties] on a parameter, it results in a one level deep iteration of the parameter's properties. If you want to go deeper, you need to apply [LogProperties] on each property you want to go deeper on. At any point, you can AtSymbolsTestExtensions apply [TagProvider] to invoke user-controlled code instead of using the automatic way. - Rename LogPropertiesAttribute.OmitParameterName to OmitReferenceName since the attribute can now be used on properties as well as parameters. - Fully support the LoggerMessageAttribute constructors. Prior logic was still based on the similar-but-different LogMethodAttribute and was therefore missing a few corner cases. Co-authored-by: Martin Taillefer <mataille@microsoft.com> --------- Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Diogo Barbosa <diogobarbosa@microsoft.com> Co-authored-by: Martin Taillefer <mataille@microsoft.com>
geeknoid
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update dependencies from https://github.com/dotnet/aspnetcore build 20230901.19 (#4347) Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rc.2.23431.20 -> To Version 8.0.0-rc.2.23451.19 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20230901.1 (#4351) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.23451.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/aspnetcore build 20230903.2 (#4349) Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions , Microsoft.Extensions.Features , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool From Version 8.0.0-rc.2.23451.19 -> To Version 8.0.0-rc.2.23453.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Fix "DuplicateRequestName" error message missing requestName argument (#4358) Co-authored-by: Diogo Barbosa <diogobarbosa@microsoft.com> * Major update to the logging generator. (#4360) - Now has full support for modern data classifications, including combined data classifications (where two annotations apply to the same piece of state). - Fix some bugs around putting spurious @ in logging property names in certain cases. - Improved many error paths by eliminating cascading errors. You now tend to just get one clean error. - Simplify [LogProperties] and create the [TagProvider] attribute. Both features are orthogonal, they should never have been provided by a single attribute. - Dynamically adjust the name of the generated static variables in order to avoid conflicts with user-created symbols. - Harmonize transitive behavior. When you apply [LogProperties] on a parameter, it results in a one level deep iteration of the parameter's properties. If you want to go deeper, you need to apply [LogProperties] on each property you want to go deeper on. At any point, you can AtSymbolsTestExtensions apply [TagProvider] to invoke user-controlled code instead of using the automatic way. - Rename LogPropertiesAttribute.OmitParameterName to OmitReferenceName since the attribute can now be used on properties as well as parameters. - Fully support the LoggerMessageAttribute constructors. Prior logic was still based on the similar-but-different LogMethodAttribute and was therefore missing a few corner cases. Co-authored-by: Martin Taillefer <mataille@microsoft.com> * Rename Metering to Metrics (#4361) Co-authored-by: Martin Taillefer <mataille@microsoft.com> --------- Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Diogo Barbosa <diogobarbosa@microsoft.com> Co-authored-by: Martin Taillefer <mataille@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4357 to release/8.0
/cc @xakep139 @dbarbosapn
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Microsoft Reviewers: Open in CodeFlow