Address issue with legacy logger's calling ToString on the TState arguments. #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
force-pushed
the
geeknoid/log
branch
from
c9d7ba8
to
fc8fa8e
Compare
|
@geeknoid could you please update the subject giving a more meaningful message? Having "Fix #123" in the git history isn't' very meaningful. At the same that information is great to have in the body of the commit because that makes GitHub create cross-references. |
RussKie
added
the
waiting-author-feedback 📭
geeknoid
changed the title
ghost
removed
the
waiting-author-feedback 📭
RussKie
reviewed
Dec 10, 2023
src/Libraries/Microsoft.Extensions.Diagnostics.Testing/Logging/FakeLogRecord.cs
Outdated
Show resolved
Hide resolved
test/Libraries/Microsoft.Extensions.Telemetry.Tests/Logging/ExtendedLoggerTests.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.LegacyTagJoiner.cs
Show resolved
Hide resolved
iliar-turdushev
approved these changes
Dec 11, 2023
…/FakeLogRecord.cs
geeknoid
force-pushed
the
geeknoid/log
branch
from
2151468
to
d61dea0
Compare
sebastienros
added a commit
that referenced
this pull request
Dec 18, 2023
* Address issue with legacy logger's calling ToString on the TState arguments. (#4798) * Fix #4795 And while I was in the neighborhood, also addresses #4637 --------- Co-authored-by: Martin Taillefer <mataille@microsoft.com> Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com> * Add missing [GeneratedCode] attribute (#4802) The logging code generator emits a static lambda. The lambda's containing function is annotated with the [GeneratedCode] attribute, but the lambda itself is not. The result is that code generators can get confused, considering the lambda as being user code. This PR adds the [GeneratedCode] attribute to the lambda. Co-authored-by: Martin Taillefer <mataille@microsoft.com> * Add more information and sample to Http.Diagnostics Readme (#4808) * Add more information and sample to Http.Diagnostics Readme * Simplify first statement and adding using statements. * Also add extra docs to xml docs * Improve code coverage for M.E.Diagnostics.Testing (#4820) --------- Co-authored-by: Martin Taillefer <geeknoid@users.noreply.github.com> Co-authored-by: Martin Taillefer <mataille@microsoft.com> Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com> Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com> Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4795
And while I was in the neighborhood, also fixes #4637
Microsoft Reviewers: Open in CodeFlow