Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log outgoing HTTP path parameters in Structured mode #4845

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

xakep139
Copy link
Contributor

@xakep139 xakep139 commented Dec 29, 2023

Fixes #4698

Microsoft Reviewers: Open in CodeFlow

@xakep139 xakep139 added this to the 8.1 milestone Dec 29, 2023
@xakep139 xakep139 self-assigned this Dec 29, 2023
@xakep139 xakep139 linked an issue Dec 29, 2023 that may be closed by this pull request
@@ -42,6 +42,7 @@
<PackageReference Include="Microsoft.Extensions.Http" />
<PackageReference Include="System.Text.Json" />
<PackageReference Include="System.Collections.Immutable" Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))" />
<PackageReference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net462'" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to update the implicit reference of 4.3.0 which is vulnerable

@xakep139 xakep139 enabled auto-merge (squash) January 2, 2024 16:58
@xakep139 xakep139 merged commit 3e24058 into main Jan 2, 2024
6 checks passed
@xakep139 xakep139 deleted the xakep139/4698-httpclient-logging-log-path-params branch January 2, 2024 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient logging doesn't log path parameters in Structured mode
3 participants