-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log outgoing HTTP path parameters in Structured mode #4845
Merged
xakep139
merged 4 commits into
main
from
xakep139/4698-httpclient-logging-log-path-params
Jan 2, 2024
Merged
Log outgoing HTTP path parameters in Structured mode #4845
xakep139
merged 4 commits into
main
from
xakep139/4698-httpclient-logging-log-path-params
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
reviewed
Dec 29, 2023
src/Libraries/Microsoft.Extensions.Http.Diagnostics/Logging/Internal/Log.cs
Show resolved
Hide resolved
geeknoid
approved these changes
Dec 29, 2023
...aries/Microsoft.Extensions.Http.Diagnostics/Logging/Internal/LoggerMessageStateExtensions.cs
Show resolved
Hide resolved
iliar-turdushev
approved these changes
Jan 2, 2024
xakep139
commented
Jan 2, 2024
@@ -42,6 +42,7 @@ | |||
<PackageReference Include="Microsoft.Extensions.Http" /> | |||
<PackageReference Include="System.Text.Json" /> | |||
<PackageReference Include="System.Collections.Immutable" Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))" /> | |||
<PackageReference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net462'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to update the implicit reference of 4.3.0 which is vulnerable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4698
Microsoft Reviewers: Open in CodeFlow