Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context switching can affect timer triggering #4861

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

mapogolions
Copy link
Contributor

@mapogolions mapogolions commented Jan 6, 2024

Fixes #4859

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned mapogolions Jan 6, 2024
@mapogolions mapogolions changed the title Context switching may affect timer triggering Context switching can affect timer triggering Jan 8, 2024
geeknoid
geeknoid previously approved these changes Jan 8, 2024
@geeknoid geeknoid closed this Jan 8, 2024
@geeknoid geeknoid reopened this Jan 8, 2024
@geeknoid geeknoid enabled auto-merge (squash) January 8, 2024 18:43
@geeknoid geeknoid self-requested a review January 8, 2024 20:37
@geeknoid
Copy link
Member

geeknoid commented Jan 8, 2024

This seems to be failing some tests.

Please add the test case from the bug report to the existing test suite to show that the fix addresses the bug and the bug stays fixed moving forward.

@geeknoid geeknoid dismissed their stale review January 8, 2024 20:39

Need more data

@geeknoid geeknoid disabled auto-merge January 8, 2024 20:39
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Http.Diagnostics 91 94

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=519756&view=codecoverage-tab

@geeknoid geeknoid merged commit 3330486 into dotnet:main Jan 9, 2024
6 checks passed
@ghost ghost added this to the 8.1 milestone Jan 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context switching can affect timer triggering
3 participants