Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HttpClient's timeout for Standard Resilience and Hedging #4862

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 8, 2024

Closes #4770

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned martintmk Jan 8, 2024
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Http.Diagnostics 91 94

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=517646&view=codecoverage-tab

@geeknoid geeknoid merged commit 3654748 into main Jan 8, 2024
6 checks passed
@geeknoid geeknoid deleted the mtomka/standard-resilince-httpclient-timeout branch January 8, 2024 18:32
@ghost ghost added this to the 8.1 milestone Jan 8, 2024
joperezr added a commit that referenced this pull request Feb 7, 2024
joperezr added a commit that referenced this pull request Feb 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient.Timeout overrides the TotalRequestTimeout when using AddStandardResilienceHandler
4 participants