Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added notes to the docs about thread safety of implementations of IAsyncState, IAsyncContext<T> and IAsyncLocalContext<T> #4881

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Added notes to the docs about thread safety of implementations of IAsyncState, IAsyncContext<T> and IAsyncLocalContext<T> #4881

merged 3 commits into from
Jan 16, 2024

Conversation

mobratil
Copy link
Contributor

@mobratil mobratil commented Jan 15, 2024 •
edited by ghost
Loading

This PR contains following changes:

  • Added notes to README.md files of Microsoft.Extensions.AsyncState and Microsoft.AspNetCore.AsyncState that implementations of IAsyncState, IAsyncContext and IAsyncLocalContext are not thread safe.
  • XML doc was extended to mention thread safety considerations
  • Reverted prior changes (Make AsyncState thread safe #4833) that tried to make Microsoft.Extensions.AsyncState thread safe,
Microsoft Reviewers: Open in CodeFlow

Martin Obratil added 2 commits January 15, 2024 21:48
@ghost ghost assigned mobratil Jan 15, 2024
@mobratil mobratil changed the title Added notes about thread safety of implementations of IAsyncState, IAsyncContext<T> and IAsyncLocalContext<T> Added notes to the docs about thread safety of implementations of IAsyncState, IAsyncContext<T> and IAsyncLocalContext<T> Jan 15, 2024
@mobratil mobratil marked this pull request as ready for review January 15, 2024 21:42
@mobratil mobratil mentioned this pull request Jan 15, 2024
Closed
@mobratil mobratil linked an issue Jan 15, 2024 that may be closed by this pull request
Thread safety of IAsyncContext<T> #4623
Closed
@mobratil mobratil merged commit f75874b into main Jan 16, 2024
6 checks passed
@mobratil mobratil deleted the maobrati/note_about_thread_safety_in_async_state branch January 16, 2024 19:36
@ghost ghost added this to the 8.1 milestone Jan 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geeknoid geeknoid geeknoid approved these changes

Assignees

@mobratil mobratil

Labels
None yet
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

Thread safety of IAsyncContext<T>
2 participants
@mobratil @geeknoid