Address a couple log generator issues. #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
geeknoid
force-pushed
the
geeknoid/logging
branch
from
2dc7395
to
1f7c454
Compare
reyang
reviewed
Jan 19, 2024
reyang
approved these changes
Jan 19, 2024
- Fix a bug where a tag provider attached to an enumerable parameter or property wouldn't behave as expected. Fixes #4883. - When an event id is not specified, instead of emitting 0 for the the id, we now hash the event name and/or method name. This matches the behavior of the generator in dotnet/runtime and is generally more useful.
geeknoid
force-pushed
the
geeknoid/logging
branch
from
1f7c454
to
ba8f730
Compare
xakep139
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where a tag provider attached to an enumerable parameter or property wouldn't behave as expected. Fixes [TagProvider] doesn't work on IEnumerable properties #4883.
When an event id is not specified, instead of emitting 0 for the the id, we now hash the event name and/or method name. This matches the behavior of the generator in dotnet/runtime and is generally more useful.
Microsoft Reviewers: Open in CodeFlow