Address remaining trim warnings #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
commented
Feb 21, 2024
| @@ -142,6 +143,11 @@ public static IStandardHedgingHandlerBuilder AddStandardHedgingHandler(this IHtt | |||
| return new StandardHedgingHandlerBuilder(builder.Name, builder.Services, routingBuilder); | |||
| } | |||
|
|
|||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode", | |||
| Justification = "The EmptyResilienceStrategyOptions doesn't have any properties to validate.")] | |||
| private static ResiliencePipelineBuilder<HttpResponseMessage> AddStrategy(this ResiliencePipelineBuilder<HttpResponseMessage> builder, Func<StrategyBuilderContext, ResilienceStrategy> factory) => | |||
There was a problem hiding this comment.
@martintmk - do you think Polly could expose this API instead? That way callers wouldn't have to define an empty ResilienceStrategyOptions class and suppress the warning.
There was a problem hiding this comment.
I think we could. Could you create an issue in Polly repo?
There was a problem hiding this comment.
Done. App-vNext/Polly#1985
RussKie
reviewed
Feb 21, 2024
Comment on lines
-19
to
-20
| <!-- See https://github.com/dotnet/extensions/issues/4395 --> | ||
| <NoWarn>$(NoWarn);TBD</NoWarn> |
RussKie
approved these changes
Feb 21, 2024
geeknoid
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4002
FYI @EricStG
Microsoft Reviewers: Open in CodeFlow