Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback from R9 review #5012

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Feedback from R9 review #5012

merged 5 commits into from
Mar 14, 2024

Conversation

MrJosman
Copy link
Contributor

@MrJosman MrJosman commented Mar 9, 2024 •
edited by dotnet-policy-service bot
Loading

Changes on Contextual Options based on the feedback provided by the official review -> Pull Request 968281: API.Microsoft.Extensions.Options.Contextual

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Options.Contextual Line 100 98.41 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=596515&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Options.Contextual Line 100 98.32 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=596519&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Options.Contextual Line 100 96.23 🔻
Microsoft.Extensions.Options.Contextual Branch 100 94.74 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=598797&view=codecoverage-tab

@RussKie RussKie marked this pull request as draft March 12, 2024 00:42
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Options.Contextual Line 100 98.11 🔻
Microsoft.Extensions.Options.Contextual Branch 100 94.74 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=598862&view=codecoverage-tab

@geeknoid
Copy link
Member

@RussKie Why did you flip this PR to a draft?

@MrJosman
Copy link
Contributor Author

@dotnet-policy-service agree company="Microsoft"

@dotnet-policy-service agree company="Microsoft"

@RussKie
Copy link
Member

RussKie commented Mar 12, 2024

@RussKie Why did you flip this PR to a draft?

As it was actively worked on and the build was failing.

@RussKie RussKie marked this pull request as ready for review March 12, 2024 21:36
@geeknoid geeknoid merged commit 201cc4d into dotnet:main Mar 14, 2024
6 checks passed
@MrJosman MrJosman deleted the Issue-5011 branch March 17, 2024 02:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

@grbell-ms grbell-ms grbell-ms approved these changes

@geeknoid geeknoid geeknoid approved these changes

Assignees

@MrJosman MrJosman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrJosman @dotnet-comment-bot @geeknoid @RussKie @grbell-ms