-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard new inter-branch merge flow [Configuration] #5239
Onboard new inter-branch merge flow [Configuration] #5239
Conversation
@joperezr Could you please check this PR/ is this something that you would like to take into the dotnet/extension? |
@f-alizada could you help us understand how we could check this PR? Is this ready for review? How do we know it is working? |
I am so sorry for the delay in the response here, I've been swamped lately. Thank you for the PR, we want to keep the main to dev subscription, but the release/8.0 one we don't really need it anymore. |
@RussKie sorry I have context here, they are deprecating the inter-branch flow PRs from maestro and instead moving to GH Actions, so this is the PR moving the existing subscriptions we have in maestro to that. |
Thank you @joperezr! @RussKie Thank you for the questions! Let me try to answer them
Yes the PR is ready for the review. The reason of the PR being in the draft state is because this PR is a suggestion on the usage of the workflow. The workflow provides possibility to configure the file_name of configuration file, the branch from where the configuration should be read, some specific triggers for the workflow that repository will benefit from having. It is up to the repository maintaners/owners to decide how to use the workflow.
The PR and the workflow could be checked on the forked repository, or merged and monitored. So far this workflow is already being used by multiple repositories Please let me know if that helps :) |
Thank you for the explanation. |
Context
Onboarding new merge flow based on the github actions
Changes Made
Added configuration file. The flow was copied from: https://github.com/dotnet/versions/blob/main/Maestro/subscriptions.json. Currently it will not be read or change any behaviour of the merge flow but will be used by the new workflow.
References
Documentation https://github.com/dotnet/arcade/blob/main/Documentation/Maestro/New-Inter-Branch-Merge-Approach.md
One pager: https://github.com/dotnet/dnceng/blob/main/Documentation/OnePagers/github-action-inter-branch-merge.md
Microsoft Reviewers: Open in CodeFlow