Logging generator: Handle multiple type definitions #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusclay
changed the title
dariusclay
commented
Aug 12, 2024
dariusclay
changed the title
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=772805&view=codecoverage-tab |
RussKie
reviewed
Aug 12, 2024
…s-loggermessage-code-generation
iliar-turdushev
approved these changes
Aug 13, 2024
|
This comment was marked as resolved.
This comment was marked as resolved.
RussKie
approved these changes
Aug 13, 2024
test/Generators/Microsoft.Gen.Logging/Unit/CompilationHelper.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
dariusclay
deleted the
5173-microsoftextensionshttpresilience-breaks-loggermessage-code-generation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5173
Microsoft Reviewers: Open in CodeFlow