Use the same JsonSerializerOptions default in all locations. #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
Oct 10, 2024
| /// <summary>Lazily-initialized default options instance.</summary> | ||
| private static AIFunctionFactoryCreateOptions? _defaultOptions; | ||
|
|
||
| /// <summary>Creates an <see cref="AIFunction"/> instance for a method, specified via a delegate.</summary> | ||
| /// <param name="method">The method to be represented via the created <see cref="AIFunction"/>.</param> | ||
| /// <returns>The created <see cref="AIFunction"/> for invoking <paramref name="method"/>.</returns> | ||
| [RequiresUnreferencedCode(UsesReflectionJsonSerializerMessage)] |
There was a problem hiding this comment.
A number of these overloads are now redundant, but I defer to @stephentoub when and when they should be removed.
There was a problem hiding this comment.
Which are redundant / would you want to remove? Do you mean making the AIFunctionFactoryCreateOptions optional on the other overload?
There was a problem hiding this comment.
I'd be ok if you wanted to consolidate them here. I'm more concerned about batching up breaking binary changes to the object model, as those are the things we'd expect nuget packages to be impacted by. AIFunctionFactory is less relevant there.
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ChatClientStructuredOutputExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 10, 2024
stephentoub
reviewed
Oct 10, 2024
src/Libraries/Microsoft.Extensions.AI/Functions/AIFunctionFactoryCreateOptions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 10, 2024
stephentoub
approved these changes
Oct 10, 2024
This was referenced Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And removes all remaining RUC/RDC annotations from the codebase.
Microsoft Reviewers: Open in CodeFlow