-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata reports generator (Issue #3999) #5531
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
@@ -21,11 +21,15 @@ public Emitter() | |||
} | |||
|
|||
[SuppressMessage("Performance", "LA0002:Use 'Microsoft.Extensions.Text.NumericExtensions.ToInvariantString' for improved performance", Justification = "Can't use that in a generator")] | |||
public string Emit(IReadOnlyCollection<ClassifiedType> classifiedTypes, string assemblyName) | |||
public string Emit(IReadOnlyCollection<ClassifiedType> classifiedTypes, string assemblyName, bool includeName = true) // show or hide assemblyName in the report,defaulted to true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added because you have a new reported dependent on this , and Compliance report is only a part of that bigger report, which have the assemblyName at the very top of it.
so we dont need to replicate the assemblyName in the properties.
The value is defaulted to true, to avoid any breaking changes for backward computability
@dotnet/dotnet-extensions-fundamentals please review |
@dotnet/dotnet-extensions-compliance @dotnet/dotnet-extensions-telemetry please review |
This Pull request fixes #3999
if you have any notes I will fix them at once, thank you
Microsoft Reviewers: Open in CodeFlow