Skip to content

Bump FunctionInvokingChatClient.MaximumIterationsPerRequest from 10 to 40 #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Bump FunctionInvokingChatClient.MaximumIterationsPerRequest from 10 to 40 #6599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public partial class FunctionInvokingChatClient : DelegatingChatClient
private readonly ActivitySource? _activitySource;

/// <summary>Maximum number of roundtrips allowed to the inner client.</summary>
private int _maximumIterationsPerRequest = 10;
private int _maximumIterationsPerRequest = 40; // arbitrary default to prevent runaway execution

/// <summary>Maximum number of consecutive iterations that are allowed contain at least one exception result. If the limit is exceeded, we rethrow the exception instead of continuing.</summary>
private int _maximumConsecutiveErrorsPerRequest = 3;
Expand Down Expand Up @@ -142,7 +142,7 @@ public static FunctionInvocationContext? CurrentContext
/// </summary>
/// <value>
/// The maximum number of iterations per request.
/// The default value is 10.
/// The default value is 40.
/// </value>
/// <remarks>
/// <para>
Expand Down
4 changes: 2 additions & 2 deletions ...Libraries/Microsoft.Extensions.AI.Tests/ChatCompletion/FunctionInvokingChatClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void Ctor_HasExpectedDefaults()

Assert.False(client.AllowConcurrentInvocation);
Assert.False(client.IncludeDetailedErrors);
Assert.Equal(10, client.MaximumIterationsPerRequest);
Assert.Equal(40, client.MaximumIterationsPerRequest);
Assert.Equal(3, client.MaximumConsecutiveErrorsPerRequest);
Assert.Null(client.FunctionInvoker);
}
Expand All @@ -55,7 +55,7 @@ public void Properties_Roundtrip()
client.IncludeDetailedErrors = true;
Assert.True(client.IncludeDetailedErrors);

Assert.Equal(10, client.MaximumIterationsPerRequest);
Assert.Equal(40, client.MaximumIterationsPerRequest);
client.MaximumIterationsPerRequest = 5;
Assert.Equal(5, client.MaximumIterationsPerRequest);

Expand Down
Loading