Fix handling of multiple responses messages #6627
Merged
+122
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with handling multiple response messages from the OpenAI Response API. The fix addresses a bug where multiple response messages with different IDs were being merged into a single message instead of being treated as separate messages.
- Adds logic to detect when a new message with a different ID should create a separate ChatMessage instance
- Removes a redundant property assignment that was adding the message ID to AdditionalProperties
- Includes comprehensive test coverage for the multiple response messages scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponseChatClient.cs | Adds logic to create new ChatMessage instances when processing multiple response messages with different IDs |
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIResponseClientTests.cs | Adds test case to verify correct handling of multiple output messages in non-streaming scenarios |
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponseChatClient.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 18, 2025
This was referenced Aug 13, 2025
Merged
Closed
This was referenced Aug 15, 2025
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6626
Microsoft Reviewers: Open in CodeFlow