-
Notifications
You must be signed in to change notification settings - Fork 839
Add OpenTelemetrySpeechToTextClient and friends #6845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is basically the chat client OpenTelemetry client copy/pasted/tweaked to compile. The otel spec doesn't have anything specific to this modality yet, so this is making best guesses on what things should be and also being minimal in what's tracked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds OpenTelemetry support for speech-to-text clients by implementing OpenTelemetry telemetry tracking that follows the OpenTelemetry Semantic Conventions for Generative AI systems. The implementation includes comprehensive activity tracing, metrics collection, and sensitive data handling options.
- Adds OpenTelemetrySpeechToTextClient with full telemetry support including activities, metrics, and error tracking
- Provides builder extension methods for easy integration into the speech-to-text client pipeline
- Includes comprehensive test coverage for both streaming and non-streaming scenarios with sensitive data handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
OpenTelemetrySpeechToTextClient.cs | Core implementation with activity tracing, metrics collection, and response handling for both streaming and non-streaming operations |
OpenTelemetrySpeechToTextClientBuilderExtensions.cs | Extension methods to add OpenTelemetry support to the speech-to-text client builder pipeline |
OpenTelemetrySpeechToTextClientTests.cs | Comprehensive test suite covering streaming/non-streaming scenarios and sensitive data configuration |
SpeechToTextClientBuilder.cs | Documentation fixes changing "audio transcription" references to "speech-to-text" |
LoggingSpeechToTextClientBuilderExtensions.cs | Documentation fix changing "audio transcription" to "speech-to-text" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This is basically the chat client OpenTelemetry client copy/pasted/tweaked to compile. The otel spec doesn't have anything specific to this modality yet, so this is making best guesses on what things should be and also being minimal in what's tracked, effectively a pure subset of what chat client outputs.
Microsoft Reviewers: Open in CodeFlow