Scope Ollama resilience settings to Web/Program.cs and restore ServiceDefaults #6850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsions.cs in ServiceDefaults
ViveliDuCh
added
area-ai
jozkee
reviewed
Sep 25, 2025
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR scopes Ollama-specific HTTP resilience settings to the web project only, restoring standard global HTTP client configuration in ServiceDefaults. The change prevents unintended global configuration changes and aligns with .NET Aspire template conventions by keeping Ollama-specific timeouts isolated to where they're needed.
Key changes:
- Moved Ollama-specific resilience configuration from ServiceDefaults to Web project
- Created dedicated extension method for Ollama HTTP client resilience settings
- Updated template configuration to conditionally include the new extension file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Program.Aspire.cs | Adds conditional call to Ollama-specific HTTP resilience configuration |
| AspireOllamaResilienceHandlerExtensions.cs | New extension method containing Ollama-specific HTTP client resilience settings |
| Extensions.cs | Removes Ollama-specific configuration, restores standard resilience handler |
| template.json | Updates template configuration to conditionally include new extension file |
...es/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/OllamaResilienceHandlerExtensions.cs
Show resolved
Hide resolved
ViveliDuCh
force-pushed
the
ollama-issue
branch
from
443c258 to
b473e1e
Compare
…ndler settings instead of the hardcoded calls in Web/Program.cs
ViveliDuCh
force-pushed
the
ollama-issue
branch
from
b473e1e to
3c3ebe6
Compare
jeffhandley
reviewed
Sep 30, 2025
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Outdated
Show resolved
Hide resolved
...es/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/OllamaResilienceHandlerExtensions.cs
Show resolved
Hide resolved
.../ChatWithCustomData/ChatWithCustomData-CSharp.Web/AspireOllamaResilienceHandlerExtensions.cs
Outdated
Show resolved
Hide resolved
jozkee
approved these changes
Sep 30, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 1, 2025
…eDefaults (dotnet#6850) Move Ollama-specific HTTP client resiliency configuration out of Extensions.cs in ServiceDefaults to an extension method called later in Web/Program.cs.
jeffhandley
pushed a commit
that referenced
this pull request
Oct 2, 2025
…eDefaults (#6850) Move Ollama-specific HTTP client resiliency configuration out of Extensions.cs in ServiceDefaults to an extension method called later in Web/Program.cs.
This was referenced Oct 14, 2025
Open
Merged
This was referenced Oct 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6331
Restore standard global HTTP client resilience configuration in
ServiceDefaults/Program.cs, removing Ollama-specific timeouts and settings. Apply extended timeouts and custom resilience handlers only tochat_httpClientandembeddings_httpClientinWeb/Program.csusingRemoveAllResilienceHandlersandAddStandardResilienceHandler. Scope Ollama configuration to the web project to prevent unintended global changes and align with .NET Aspire template conventions.Microsoft Reviewers: Open in CodeFlow