Skip to content

Conversation

Varorbc
Copy link
Contributor

@Varorbc Varorbc commented Sep 26, 2025

Microsoft Reviewers: Open in CodeFlow

@Varorbc Varorbc requested a review from a team as a code owner September 26, 2025 09:56
@github-actions github-actions bot added the area-ai-templates Microsoft.Extensions.AI.Templates label Sep 26, 2025
@stephentoub
Copy link
Member

@jeffhandley, test failures are with the AI templates

@Varorbc Varorbc force-pushed the main branch 2 times, most recently from 4d15019 to d7136db Compare September 30, 2025 05:30
@Varorbc
Copy link
Contributor Author

Varorbc commented Sep 30, 2025

@stephentoub all green

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thank you, @Varorbc! I'm going to run some additional manual testing before merge.

@jeffhandley jeffhandley added the * NO MERGE * Do not merge this PR as long as this label is present. label Sep 30, 2025
@jeffhandley
Copy link
Member

I'm seeing end-to-end functional test issues trying to run Aspire applications using Aspire services. It looks like we're going to need to update the generated README instructions for getting the Azure resources ready and getting the services running through the Aspire dashboard.

@Varorbc
Copy link
Contributor Author

Varorbc commented Sep 30, 2025

@jeffhandley What else do I need to do?

@jeffhandley
Copy link
Member

Thanks again, @Varorbc. With the README changes that @MackinnonBuck pushed, this is good to go now.

@jeffhandley jeffhandley merged commit af84086 into dotnet:main Sep 30, 2025
6 checks passed
@jeffhandley jeffhandley removed the * NO MERGE * Do not merge this PR as long as this label is present. label Oct 1, 2025
jeffhandley pushed a commit to jeffhandley/extensions that referenced this pull request Oct 1, 2025
* Update Aspire

* Update Aspire template README

---------

Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
jeffhandley pushed a commit to jeffhandley/extensions that referenced this pull request Oct 1, 2025
* Update Aspire

* Update Aspire template README

---------

Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
jeffhandley pushed a commit to jeffhandley/extensions that referenced this pull request Oct 1, 2025
* Update Aspire

* Update Aspire template README

---------

Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
jeffhandley pushed a commit that referenced this pull request Oct 2, 2025
* Update Aspire

* Update Aspire template README

---------

Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
This was referenced Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ai-templates Microsoft.Extensions.AI.Templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants