-
Notifications
You must be signed in to change notification settings - Fork 839
Update to .NET 10 SDK #6863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 10 SDK #6863
Conversation
- Add InterceptorsNamespaces - Fix formatting - Remove unused members - Suppress IDE0032 and IDE0040 (for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the .NET Extensions repository to use the .NET 10 SDK and updates the associated dotnet/arcade tooling. The change maintains the same Target Framework Monikers (TFMs) for builds while upgrading the SDK version and addressing new analyzer violations that arose with the update.
- Updates global.json to use .NET 10 SDK version 10.0.100-rc.1.25451.107
- Updates Microsoft.DotNet.Arcade.Sdk and related packages to version 10.0.0-beta.25476.2
- Addresses new analyzer violations by disabling IDE0032 and IDE0040 in .editorconfig files
- Removes redundant package references that are now included in the framework
- Updates test code to handle changes in ASP.NET Core header parsing APIs
Reviewed Changes
Copilot reviewed 82 out of 84 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
global.json | Updates .NET SDK version to 10.0.100-rc.1.25451.107 and arcade packages to 10.0.0-beta.25476.2 |
eng/Version.Details.xml | Updates arcade toolset dependency versions and commit SHA references |
eng/Versions.props | Updates Microsoft.DotNet.Build.Tasks.Templating version and adds XUnitRunnerVisualStudioVersion |
test/.editorconfig, src/Shared/.editorconfig, src/Libraries/.editorconfig | Silences IDE0032 and IDE0040 analyzer warnings |
Multiple test files | Adds blank lines after namespace declarations to satisfy new formatting requirements |
Multiple project files | Removes redundant package references now included in framework |
Source files | Updates code to work around new analyzer violations with pragma warnings |
Test files | Updates header parsing tests to call ToString() method on new StringSegment types |
eng/common/* | Updates arcade common files with .NET 10 SDK support and tooling improvements |
src/Libraries/Microsoft.Extensions.Caching.Hybrid/Internal/DefaultJsonSerializerFactory.cs
Outdated
Show resolved
Hide resolved
...ft.Extensions.Compliance.Abstractions.Tests/Redaction/RedactionAbstractionsExtensionsTest.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.AspNetCore.HeaderParsing/Microsoft.AspNetCore.HeaderParsing.csproj
Show resolved
Hide resolved
test/Generators/Microsoft.Gen.Logging/Unit/LogParserUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI is green, this LGTM. Thanks so much for taking care of this @eerhardt!
Bringing in the .NET 10 SDK and dotnet/arcade. No changes to which TFMs we build for in this PR. That will come in a later change.
There are a few new analyzer violations that I needed to work around.
Microsoft Reviewers: Open in CodeFlow