Adjust cgroupv2 drive format check for .NET 10 and higher #6877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the cgroup v2 drive format check to account for a change in .NET 10 where the drive format string for cgroup2 filesystems changed from "cgroup2fs" to "cgroup2". The change uses conditional compilation directives to maintain backward compatibility.
Key changes:
- Updates the
CgroupVersionconstant to use different values based on .NET version - Uses conditional compilation to target .NET 10+ vs earlier versions
KeterSCP
commented
Oct 1, 2025
| var injectParserV2 = false; | ||
| const string CgroupVersion = "cgroup2fs"; | ||
| const string CgroupVersion = | ||
| #if NET10_0_OR_GREATER |
There was a problem hiding this comment.
Note: this will start working once the repository starts targeting .NET 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6832
I cannot run tests locally because of #6463
Microsoft Reviewers: Open in CodeFlow