Add FolderWorkspace and flag to find files by folder #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmarolf please take a look |
JoeRobich
force-pushed
the
add-folderworkspace
branch
2 times, most recently
from
bf91875
to
9253b41
Compare
|
I'll review this today |
JoeRobich
force-pushed
the
add-folderworkspace
branch
from
9253b41
to
cf6238c
Compare
jmarolf
approved these changes
Aug 27, 2019
|
@JoeRobich what is the perf difference here? |
JoeRobich
force-pushed
the
add-folderworkspace
branch
from
cf6238c
to
fae06aa
Compare
|
@jmarolf for dotnet/format it goes from being ~4s down to ~1.5s |
JoeRobich
force-pushed
the
add-folderworkspace
branch
16 times, most recently
from
f4a57d4
to
1c45e81
Compare
JoeRobich
force-pushed
the
add-folderworkspace
branch
3 times, most recently
from
cd02308
to
63b8fb0
Compare
JoeRobich
force-pushed
the
add-folderworkspace
branch
from
63b8fb0
to
04670cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FolderWorkspace treats code files beneath the folder as part of the Solution. This workspace wouldn't be suitable to future analyzer/codefix work since semantic information wouldn't be available, but it does suffice to provide a faster path for whitespace formatting.
Opt-in to this experience by using the
--folderoption instead of--workspace.