Skip to content

Commit

Permalink
Extract namespaces and put FS0988 at end of file - fixes #461
Browse files Browse the repository at this point in the history
  • Loading branch information
forki committed Nov 26, 2016
1 parent eece38d commit eb100bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/fsharp/CompileOps.fs
Original file line number Diff line number Diff line change
Expand Up @@ -3135,11 +3135,13 @@ let ComputeQualifiedNameOfFileFromUniquePath (m, p: string list) = QualifiedName
let QualFileNameOfSpecs filename specs =
match specs with
| [SynModuleOrNamespaceSig(modname,_,true,_,_,_,_,m)] -> QualFileNameOfModuleName m filename modname
| [SynModuleOrNamespaceSig(_,_,false,_,_,_,_,m)] -> QualFileNameOfFilename m filename
| _ -> QualFileNameOfFilename (rangeN filename 1) filename

let QualFileNameOfImpls filename specs =
match specs with
| [SynModuleOrNamespace(modname,_,true,_,_,_,_,m)] -> QualFileNameOfModuleName m filename modname
| [SynModuleOrNamespace(_,_,false,_,_,_,_,m)] -> QualFileNameOfFilename m filename
| _ -> QualFileNameOfFilename (rangeN filename 1) filename

let PrepandPathToQualFileName x (QualifiedNameOfFile(q)) = ComputeQualifiedNameOfFileFromUniquePath (q.idRange,pathOfLid x@[q.idText])
Expand Down
2 changes: 1 addition & 1 deletion tests/fsharpqa/Source/Warnings/FS0988AtEndOfFile.fs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// #Warnings
//<Expects status="Error" id="FS0001">This expression was expected to have type</Expects>
//<Expects status="Error" span="(7,24)" id="FS0988">Main module of program is empty: nothing will happen when it is run</Expects>

namespace MyNamespace1

Expand Down

0 comments on commit eb100bd

Please sign in to comment.