Fix unused open type declaration detection

dotnet · Nov 20, 2020 · ff6f797 · ff6f797
1 parent 7036c05
commit ff6f797
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/fsharp/service/ServiceAnalysis.fs b/src/fsharp/service/ServiceAnalysis.fs
@@ -67,9 +67,9 @@ module UnusedOpens =
                             yield! getModuleAndItsAutoOpens true ent |]
             { OpenedModules = getModuleAndItsAutoOpens false modul }
 
-    /// Represents single open statement.
+    /// Represents a single open statement
     type OpenStatement =
-        { /// All namespaces and modules which this open declaration effectively opens, including the AutoOpen ones
+        { /// All namespaces, modules and types which this open declaration effectively opens, including the AutoOpen ones
           OpenedGroups: OpenedModuleGroup list
 
           /// The range of open statement itself
@@ -90,7 +90,8 @@ module UnusedOpens =
                     if firstId.idText = MangledGlobalName then 
                         None
                     else
-                        Some { OpenedGroups = openDecl.Modules |> List.map OpenedModuleGroup.Create
+                        let openedModulesAndTypes = List.concat [openDecl.Modules; openDecl.Types |> List.map(fun ty -> ty.TypeDefinition)]
+                        Some { OpenedGroups = openedModulesAndTypes |> List.map OpenedModuleGroup.Create
                                Range = range
                                AppliedScope = openDecl.AppliedScope }
                 | _ -> None)

diff --git a/vsintegration/tests/UnitTests/UnusedOpensTests.fs b/vsintegration/tests/UnitTests/UnusedOpensTests.fs
@@ -808,4 +808,13 @@ open Nested
 
 let _ = f 1
 """
-    => []
+    => []
+
+[<Test>]
+let ``open type``() =
+    """
+open type System.Console
+
+WriteLine("Hello World")
+    """
+    => [2, (10, 24)]