-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseAndCheckFileInProject fails #10303
Comments
I'm hitting this failure as well when updating FSHarp.Formatting to use latest FCS
I agree @baronfel Have you noticed this issue with people using latest FCS? |
Yes, many consumers have had to add this package (including things like sharplab and xunit). |
We've had to workaround it by temporarily deleting the references and related code in our FCS build. |
I take it this still an issue with FCS 38.0.2? I don't think we can get rid of the dependency but it should at least be added to the nuspec. |
Closing out older issue due to needs more info |
Running
FSharpChecker.ParseAndCheckFileInProject
fails with creation error returned:It happens due to extra FCS dependencies were added in #9870: https://github.com/dotnet/fsharp/pull/9870/files#diff-f80f13c95d4e5cb2e376c9f82051683af78316220d065db8470e4894b096c46fR731-R733
Removing the references (and moving the related code to
#if
makes it work as expected (since the moved declarations aren't used innetsandard2.0
FCS anyway).I believe FCS should not depend on MSBuild directly like this, since it quite constraints the environment FCS could be used in.
The text was updated successfully, but these errors were encountered: