Netstandard2.0 FSharp.Core in master + netcoreapp3.1 fix for tests #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Net standard only FSharp.Core * temp
vzarytovskii
changed the title
|
Okay some hiccups with windows tests, going to look at those. |
cartermp
approved these changes
Aug 5, 2020
KevinRansom
approved these changes
Aug 6, 2020
abelbraaksma
pushed a commit
to abelbraaksma/fsharp
that referenced
this pull request
Aug 9, 2020
…otnet#9870) * Net Standard 2.0 only FSharp.Core (dotnet#9801) * Net standard only FSharp.Core * temp * Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests * Fixed netcoreapp30 -> netcoreapp31 test references * Cleaned up projects, added testplatform package, moved some tests to new suite * Tests changes * Revert accidental revert * Added missing tests * Cleaned up packages, fixed tests * Add System.Runtime to references Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
vzarytovskii
added
Area-Testing Infrastructure
and removed
Area-Infrastructure
Area-Testing
labels
dsyme
reviewed
Dec 1, 2020
| @@ -723,6 +728,9 @@ | |||
| <PackageReference Include="System.Buffers" Version="4.5.0" /> | |||
| <PackageReference Include="System.Memory" Version="4.5.3" /> | |||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" /> | |||
| <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildVersion)" /> | |||
There was a problem hiding this comment.
These dependencies are problematic, see #10303
Also they aren't listed in the nupkg, see https://www.nuget.org/packages/FSharp.Compiler.Service/38.0.0
cc @baronfel
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…otnet#9870) * Net Standard 2.0 only FSharp.Core (dotnet#9801) * Net standard only FSharp.Core * temp * Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests * Fixed netcoreapp30 -> netcoreapp31 test references * Cleaned up projects, added testplatform package, moved some tests to new suite * Tests changes * Revert accidental revert * Added missing tests * Cleaned up packages, fixed tests * Add System.Runtime to references Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cherry pick of @KevinRansom's (#9801) to master.